Redwings Drop III: Ceikry GE, Job, Slayer, Achievement Diary rewrites

Server/src/main/kotlin/api/ContentAPI.kt

@@ -1379,11 +1379,17 @@ fun announceIfRare(player: Player, item: Item) {
  */
 
 fun getMasteredSkillNames(player: Player): List<String> {
+    val hasMastered = player.getSkills().masteredSkills > 0
     val masteredSkills = ArrayList<String>()
 
-    for ((skillId, skillName) in Skills.SKILL_NAME.withIndex()) {
-        if(hasLevelStat(player, skillId, 99)){
-            masteredSkills.add(skillName)
+    if(hasMastered){
+        for ((skillId, skillName) in Skills.SKILL_NAME.withIndex()) {
+            //phil you were looping every skill and performing a string comparison (another loop) for every one here.
+            //that's some real shit code bro.
+            //you were also performing a dynamic level check rather than a static.
+            if(hasLevelStat(player, skillId, 99)){
+                masteredSkills.add(skillName)
+            }
         }
     }
     return masteredSkills

Server/src/main/kotlin/api/LoginListener.kt

@@ -0,0 +1,7 @@
+package api
+
+import core.game.node.entity.player.Player
+
+interface LoginListener {
+    fun login(player: Player)
+}

Server/src/main/kotlin/api/events/Event.kt

@@ -0,0 +1,3 @@
+package api.events
+
+interface Event {}

Server/src/main/kotlin/api/events/EventHook.kt

@@ -0,0 +1,7 @@
+package api.events
+
+import core.game.node.entity.Entity
+
+interface EventHook<T: Event> {
+    fun process(entity: Entity, event: T)
+}

Server/src/main/kotlin/api/events/Events.kt

@@ -0,0 +1,11 @@
+package api.events
+
+import core.game.node.Node
+import core.game.node.entity.npc.NPC
+import core.game.node.entity.player.link.TeleportManager.TeleportType
+
+data class ResourceGatheredEvent(val itemId: Int, val amount: Int, val source: Node) : Event
+data class NPCKillEvent(val npc: NPC) : Event
+data class TeleportEvent(val type: TeleportType, val source: Int = -1) : Event
+data class LitFireEvent(val logId: Int) : Event
+data class InteractionEvent(val target: Node, val option: String) : Event