Alchemy value now derived from item value (from cache)

Removed all alchemy value overrides from item config json
All items should now have authentic alchemy values

Server/src/main/java/core/cache/def/impl/ItemDefinition.java

@@ -1370,9 +1370,9 @@ public class ItemDefinition extends Definition<Item> {
 			return forId(noteId).getAlchemyValue(highAlchemy);
 		}
 		if (highAlchemy) {
-			return getConfiguration(ItemConfigParser.HIGH_ALCHEMY, 0);
+			return getConfiguration(ItemConfigParser.HIGH_ALCHEMY, (int)Math.rint(value * 0.6));
 		}
-		return getConfiguration(ItemConfigParser.LOW_ALCHEMY, 0);
+		return getConfiguration(ItemConfigParser.LOW_ALCHEMY, (int)Math.rint(value * 0.4));
 	}
 
 	/**

Server/src/test/kotlin/ItemDefinitionTests.kt

@@ -0,0 +1,54 @@
+package core.cache
+
+import TestUtils
+import core.game.node.item.Item
+import org.junit.jupiter.api.Assertions
+import org.junit.jupiter.api.Test
+import org.rs09.consts.Items
+import kotlin.math.roundToInt
+
+class ItemDefinitionTests {
+    companion object {
+        init {TestUtils.preTestSetup()}
+    }
+
+    @Test fun itemHighAlchIs60PercentValueRandomItem1() {
+        val natureRune = Item(Items.NATURE_RUNE_561)
+        Assertions.assertEquals((natureRune.definition.value * 0.6).roundToInt(), natureRune.definition.getAlchemyValue(true))
+    }
+
+    @Test fun itemHighAlchIs60PercentValueRandomItem2() {
+        val tuna = Item(Items.TUNA_361)
+        Assertions.assertEquals((tuna.definition.value * 0.6).roundToInt(), tuna.definition.getAlchemyValue(true))
+    }
+
+    @Test fun itemHighAlchIs60PercentValueRandomItem3() {
+        val bass = Item(Items.BASS_365)
+        Assertions.assertEquals((bass.definition.value * 0.6).roundToInt(), bass.definition.getAlchemyValue(true))
+    }
+
+    @Test fun itemHighAlchIs60PercentValueRandomItem4() {
+        val goldBar = Item(Items.GOLD_BAR_2357)
+        Assertions.assertEquals((goldBar.definition.value * 0.6).roundToInt(), goldBar.definition.getAlchemyValue(true))
+    }
+
+    @Test fun itemLowAlchIs40PercentValueRandomItem1() {
+        val natureRune = Item(Items.NATURE_RUNE_561)
+        Assertions.assertEquals((natureRune.definition.value * 0.4).roundToInt(), natureRune.definition.getAlchemyValue(false), natureRune.name)
+    }
+
+    @Test fun itemLowAlchIs40PercentValueRandomItem2() {
+        val tuna = Item(Items.TUNA_361)
+        Assertions.assertEquals((tuna.definition.value * 0.4).roundToInt(), tuna.definition.getAlchemyValue(false), tuna.name)
+    }
+
+    @Test fun itemLowAlchIs40PercentValueRandomItem3() {
+        val bass = Item(Items.BASS_365)
+        Assertions.assertEquals((bass.definition.value * 0.4).roundToInt(), bass.definition.getAlchemyValue(false), bass.name)
+    }
+
+    @Test fun itemLowAlchIs40PercentValueRandomItem4() {
+        val goldBar = Item(Items.GOLD_BAR_2357)
+        Assertions.assertEquals((goldBar.definition.value * 0.4).roundToInt(), goldBar.definition.getAlchemyValue(false), goldBar.name)
+    }
+}