yuriy/2009scape
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reverted alchemy changes, turns out the item value data in the game cache is so unreliable it's essentially unusable

Browse Source
This commit is contained in:
Ryan
2022-05-21 17:01:27 +00:00
parent bba7c51bb2
commit 40d227d430
3 changed files with 14970 additions and 5286 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Server/data/configs/item_configs.json
+14967 -5229
View File
File diff suppressed because it is too large Load Diff
Server/src/main/java/core/cache/def/impl/ItemDefinition.java
Vendored
+2 -2
View File
@@ -1399,9 +1399,9 @@ public class ItemDefinition extends Definition<Item> {
return forId(noteId).getAlchemyValue(highAlchemy);
}
if (highAlchemy) {
return getConfiguration(ItemConfigParser.HIGH_ALCHEMY, (int)Math.rint(value * 0.6));
return getConfiguration(ItemConfigParser.HIGH_ALCHEMY, 0);
}
return getConfiguration(ItemConfigParser.LOW_ALCHEMY, (int)Math.rint(value * 0.4));
return getConfiguration(ItemConfigParser.LOW_ALCHEMY, 0);
}
/**
Server/src/test/kotlin/core/cache/ItemDefinitionTests.kt
Vendored
-54
View File
@@ -1,54 +0,0 @@
package core.cache
import TestUtils
import core.game.node.item.Item
import org.junit.jupiter.api.Assertions
import org.junit.jupiter.api.Test
import org.rs09.consts.Items
import kotlin.math.roundToInt
class ItemDefinitionTests {
companion object {
init {TestUtils.preTestSetup()}
}
@Test fun itemHighAlchIs60PercentValueRandomItem1() {
val natureRune = Item(Items.NATURE_RUNE_561)
Assertions.assertEquals((natureRune.definition.value * 0.6).roundToInt(), natureRune.definition.getAlchemyValue(true))
}
@Test fun itemHighAlchIs60PercentValueRandomItem2() {
val tuna = Item(Items.TUNA_361)
Assertions.assertEquals((tuna.definition.value * 0.6).roundToInt(), tuna.definition.getAlchemyValue(true))
}
@Test fun itemHighAlchIs60PercentValueRandomItem3() {
val bass = Item(Items.BASS_365)
Assertions.assertEquals((bass.definition.value * 0.6).roundToInt(), bass.definition.getAlchemyValue(true))
}
@Test fun itemHighAlchIs60PercentValueRandomItem4() {
val goldBar = Item(Items.GOLD_BAR_2357)
Assertions.assertEquals((goldBar.definition.value * 0.6).roundToInt(), goldBar.definition.getAlchemyValue(true))
}
@Test fun itemLowAlchIs40PercentValueRandomItem1() {
val natureRune = Item(Items.NATURE_RUNE_561)
Assertions.assertEquals((natureRune.definition.value * 0.4).roundToInt(), natureRune.definition.getAlchemyValue(false), natureRune.name)
}
@Test fun itemLowAlchIs40PercentValueRandomItem2() {
val tuna = Item(Items.TUNA_361)
Assertions.assertEquals((tuna.definition.value * 0.4).roundToInt(), tuna.definition.getAlchemyValue(false), tuna.name)
}
@Test fun itemLowAlchIs40PercentValueRandomItem3() {
val bass = Item(Items.BASS_365)
Assertions.assertEquals((bass.definition.value * 0.4).roundToInt(), bass.definition.getAlchemyValue(false), bass.name)
}
@Test fun itemLowAlchIs40PercentValueRandomItem4() {
val goldBar = Item(Items.GOLD_BAR_2357)
Assertions.assertEquals((goldBar.definition.value * 0.4).roundToInt(), goldBar.definition.getAlchemyValue(false), goldBar.name)
}
}