Runecrafting pouches now synchronise across bank instances

BoB can no longer be used to smuggle weapons to Entrana

Server/src/main/content/global/skill/runecrafting/PouchManager.kt

@@ -75,11 +75,11 @@ class PouchManager(val player: Player) {
                     pouch.currentCap = pouch.capacity
                     pouch.charges = pouch.maxCharges
                     pouch.remakeContainer()
+                    replaceAllItems(player, itemId, itemId - 1) //in case the player had more copies
                 }
             } else {
                 if (!isDecayedPouch(itemId)) {
-                    val slot = player.inventory.getSlot(Item(itemId))
-                    replaceSlot(player, slot, Item(itemId + 1))
+                    replaceAllItems(player, itemId, itemId + 1)
                 }
                 sendMessage(player, "Your pouch has decayed through use.") //https://www.youtube.com/watch?v=FUcPYrgPUlQ
                 pouch.charges = 9 * pouch.currentCap //implied by multiple contemporaneous sources, quantified only by https://oldschool.runescape.wiki/w/Large_pouch

Server/src/main/content/global/skill/runecrafting/abyss/DarkMageDialogue.java

@@ -6,6 +6,8 @@ import core.game.node.entity.player.Player;
 import core.game.node.item.Item;
 import org.rs09.consts.Items;
 
+import static core.api.ContentAPIKt.replaceAllItems;
+
 /**
  * Handles the dark mages dialogue.
  * @author Vexia
@@ -153,14 +155,7 @@ public final class DarkMageDialogue extends DialoguePlugin {
 				pouch.getContainer().add(essItem);
 			}
 			if (id != Items.SMALL_POUCH_5509) {
-				if (player.getInventory().contains(id + 1, 1)) {
-					player.getInventory().remove(new Item(id + 1, 1));
-					player.getInventory().add(new Item(id, 1));
-				}
-				if (player.getBank().contains(id + 1, 1)) {
-					player.getBank().remove(new Item(id + 1, 1));
-					player.getBank().add(new Item(id, 1));
-				}
+				replaceAllItems(player, id + 1, id);
 			}
 		});
 		return true;