Move the global 1/15 chance to not drop charms from code to data.

2021-08-28 16:05:29 -04:00
parent 0f83943d4f
commit e213e30d96
2 changed files with 905 additions and 4 deletions
@@ -19,9 +19,10 @@ class NPCDropTable : WeightBasedTable() {
        val items= ArrayList<Item>(3)
        items.addAll(guaranteedItems.map { it.getItem() }.toList())

-        if(RandomFunction.random(1,15) == 5){
-            items.addAll(charmDrops.roll(null))
-        }
+        // Charms table is always rolled, and should contain explicit "Nothing" 
+        // entries at the data level to account for the chance to not drop a charm.
+        items.addAll(charmDrops.roll(null))
+
        if(size == 1){
            items.add(get(0).getItem())
            return items
@@ -45,4 +46,4 @@ class NPCDropTable : WeightBasedTable() {
        return items
    }

-}
+}