fix: async-mutex not exclusively locking correectly
This commit is contained in:
		@@ -30,7 +30,7 @@ These correspond to following parts of the page:
 | 
			
		||||
 | 
			
		||||
Quartz **components**, like plugins, can take in additional properties as configuration options. If you're familiar with React terminology, you can think of them as Higher-order Components.
 | 
			
		||||
 | 
			
		||||
See [a list of all the components](./tags/component) for all available components along with their configuration options. You can also checkout the guide on [[creating components]] if you're interested in further customizing the behaviour of Quartz.
 | 
			
		||||
See [a list of all the components](component.md) for all available components along with their configuration options. You can also checkout the guide on [[creating components]] if you're interested in further customizing the behaviour of Quartz.
 | 
			
		||||
 | 
			
		||||
### Style
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -394,8 +394,15 @@ See the [documentation](https://quartz.jzhao.xyz) for how to get started.
 | 
			
		||||
 | 
			
		||||
    const buildMutex = new Mutex()
 | 
			
		||||
    const timeoutIds = new Set()
 | 
			
		||||
    let firstBuild = true
 | 
			
		||||
    const build = async (clientRefresh) => {
 | 
			
		||||
      await buildMutex.acquire()
 | 
			
		||||
      const release = await buildMutex.acquire()
 | 
			
		||||
      if (firstBuild) {
 | 
			
		||||
        firstBuild = false
 | 
			
		||||
      } else {
 | 
			
		||||
        console.log(chalk.yellow("Detected a source code change, doing a hard rebuild..."))
 | 
			
		||||
      }
 | 
			
		||||
 | 
			
		||||
      const result = await ctx.rebuild().catch((err) => {
 | 
			
		||||
        console.error(`${chalk.red("Couldn't parse Quartz configuration:")} ${fp}`)
 | 
			
		||||
        console.log(`Reason: ${chalk.grey(err)}`)
 | 
			
		||||
@@ -418,7 +425,7 @@ See the [documentation](https://quartz.jzhao.xyz) for how to get started.
 | 
			
		||||
      const { default: buildQuartz } = await import(cacheFile + `?update=${randomUUID()}`)
 | 
			
		||||
      await buildQuartz(argv, clientRefresh)
 | 
			
		||||
      clientRefresh()
 | 
			
		||||
      buildMutex.release()
 | 
			
		||||
      release()
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    const rebuild = (clientRefresh) => {
 | 
			
		||||
@@ -526,7 +533,6 @@ See the [documentation](https://quartz.jzhao.xyz) for how to get started.
 | 
			
		||||
          ignoreInitial: true,
 | 
			
		||||
        })
 | 
			
		||||
        .on("all", async () => {
 | 
			
		||||
          console.log(chalk.yellow("Detected a source code change, doing a hard rebuild..."))
 | 
			
		||||
          rebuild(clientRefresh)
 | 
			
		||||
        })
 | 
			
		||||
    } else {
 | 
			
		||||
 
 | 
			
		||||
@@ -108,12 +108,13 @@ async function startServing(
 | 
			
		||||
      toRemove.add(filePath)
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    timeoutIds.forEach((id) => clearTimeout(id))
 | 
			
		||||
 | 
			
		||||
    // debounce rebuilds every 250ms
 | 
			
		||||
    timeoutIds.add(
 | 
			
		||||
      setTimeout(async () => {
 | 
			
		||||
        await buildMutex.acquire()
 | 
			
		||||
        const release = await buildMutex.acquire()
 | 
			
		||||
        timeoutIds.forEach((id) => clearTimeout(id))
 | 
			
		||||
        timeoutIds.clear()
 | 
			
		||||
 | 
			
		||||
        const perf = new PerfTimer()
 | 
			
		||||
        console.log(chalk.yellow("Detected change, rebuilding..."))
 | 
			
		||||
        try {
 | 
			
		||||
@@ -134,6 +135,8 @@ async function startServing(
 | 
			
		||||
            contentMap.delete(fp)
 | 
			
		||||
          }
 | 
			
		||||
 | 
			
		||||
          // TODO: we can probably traverse the link graph to figure out what's safe to delete here
 | 
			
		||||
          // instead of just deleting everything
 | 
			
		||||
          await rimraf(argv.output)
 | 
			
		||||
          const parsedFiles = [...contentMap.values()]
 | 
			
		||||
          const filteredContent = filterContent(ctx, parsedFiles)
 | 
			
		||||
@@ -146,7 +149,7 @@ async function startServing(
 | 
			
		||||
        clientRefresh()
 | 
			
		||||
        toRebuild.clear()
 | 
			
		||||
        toRemove.clear()
 | 
			
		||||
        buildMutex.release()
 | 
			
		||||
        release()
 | 
			
		||||
      }, 250),
 | 
			
		||||
    )
 | 
			
		||||
  }
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user